Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Serialisation Fix for 8.1 #71

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Event Serialisation Fix for 8.1 #71

merged 1 commit into from
Jan 31, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jan 31, 2022

Adds magic un/serialize methods to the webhook event to avoid deprecation errors in 8.1

Verified

This commit was signed with the committer’s verified signature.
gsteel George Steel
…tion errors in 8.1
@gsteel gsteel added this to the 1.1.0 milestone Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #71 (db2be55) into main (aadff44) will decrease coverage by 1.45%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #71      +/-   ##
============================================
- Coverage     84.46%   83.01%   -1.46%     
- Complexity      196      199       +3     
============================================
  Files            37       37              
  Lines           515      524       +9     
============================================
  Hits            435      435              
- Misses           80       89       +9     
Impacted Files Coverage Δ
src/Event/WebhookEvent.php 65.38% <90.90%> (-34.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aadff44...db2be55. Read the comment docs.

@gsteel gsteel merged commit 152a883 into main Jan 31, 2022
@gsteel gsteel deleted the webhook-event-serialisable branch January 31, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant