Partial fix for #7039 #7060
Merged
Partial fix for #7039 #7060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved updater installation code to packaging/installer/functions.sh - packaging/makeself/install-or-update.sh uses above code to install netdata updater
Manage this branch in SquashTest this branch here: https://7039-netdata-updater-kickstart-s9np0.squash.io |
cakrit
reviewed
Oct 11, 2019
cosmix
suggested changes
Oct 11, 2019
cosmix
suggested changes
Oct 17, 2019
cosmix
approved these changes
Oct 17, 2019
cakrit
approved these changes
Oct 17, 2019
knatsakis
added a commit
that referenced
this pull request
Nov 6, 2019
* netdata-installer.sh: Improve message about updater installation * packaging/installer/functions.sh: get_crondir() fails if crondir is not found * packaging/installer/functions.sh: Mark get_crondir and check_crondir_permissions functions as private
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
* Partial fix for netdata#7039 Moved updater installation code from netdata-installer.sh to packaging/installer/functions.sh packaging/makeself/install-or-update.sh uses above code to install netdata updater - Moved updater installation code to packaging/installer/functions.sh - packaging/makeself/install-or-update.sh uses above code to install netdata updater * Split install_or_remove_netdata_updater() function * Improved netdata-updater related message output * Improved variable declaration location in install-or-update.sh
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
…7200) * netdata-installer.sh: Improve message about updater installation * packaging/installer/functions.sh: get_crondir() fails if crondir is not found * packaging/installer/functions.sh: Mark get_crondir and check_crondir_permissions functions as private
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
* Partial fix for netdata#7039 Moved updater installation code from netdata-installer.sh to packaging/installer/functions.sh packaging/makeself/install-or-update.sh uses above code to install netdata updater - Moved updater installation code to packaging/installer/functions.sh - packaging/makeself/install-or-update.sh uses above code to install netdata updater * Split install_or_remove_netdata_updater() function * Improved netdata-updater related message output * Improved variable declaration location in install-or-update.sh
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
…7200) * netdata-installer.sh: Improve message about updater installation * packaging/installer/functions.sh: get_crondir() fails if crondir is not found * packaging/installer/functions.sh: Mark get_crondir and check_crondir_permissions functions as private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partial fix for #7039
netdata updater
Component Name
packaging/makeself/install-or-update.sh
Additional Information
Another PR will be needed, in order to update kickstart-static64.sh and enable the netdata installer by default