kickstart: pass options to installer #7051

oxplot · 2019-10-10T11:53:55Z

pass --stable-channel option
append --dont-wait option to list of passthrough options

Summary

Passes through kickstarter options to the installer

Component Name

Packaging - Installer

Additional Information

Fixes #7040

- pass --stable-channel option - append --dont-wait option to list of passthrough options

squash-labs · 2019-10-10T11:54:03Z

Manage this branch in Squash

Test this branch here: https://oxplotpass-stable-channel-opt-ogc2j.squash.io

cosmix

Thanks for this. You need to update kickstart-static64.sh too tho, as that was also reported to be failing. Did you check that case too?

paulkatsoulakis · 2019-10-10T14:40:08Z

we also need the checksum info to be updated on packaging/installer/readme.md when modifying kickstarts

cakrit · 2019-10-10T14:56:33Z

Also @paulkatsoulakis please ensure that @knatsakis knows how to update the two scripts, once the PR is merged.

knatsakis · 2019-10-10T15:58:32Z

This looks like a good fix for kickstart.sh. But the case with kickstart-static64.sh is more complicated.

kickstart.sh does generate .environment but this is not the case for kickstart-static64.sh.

In the second case the .environment file is included in netdata-$version.gz.run. So,
.environment has to be fixed in netdata-$version.gz.run in the first place or kickstart-static64.sh must sed it

CLAassistant · 2019-10-10T16:08:10Z

All committers have signed the CLA.

ilyam8 · 2019-10-10T16:14:40Z

@oxplot please sign the CLA

knatsakis · 2019-10-10T17:22:44Z

packaging/installer/kickstart-static64.sh

@@ -194,6 +194,7 @@ while [ -n "${1}" ]; do
 		shift 1
 	elif [ "${1}" = "--stable-channel" ]; then
 		RELEASE_CHANNEL="stable"
+		inner_opts="${inner_opts} ${1}"


Hi @oxplot, are you sure that the inner script accepts the "--stable-channel" option?

oh I see — I wrongly assumed based on #7051 (review) that both scripts behave the same.

I suggest then to only fix kickstart and leave kickstart-static64 for another PR, given how trivial this fix is (so it doesn't drag on).

If i may say, @knatsakis if we have decided that through netdata-updater.sh for the static install, we want to automatically set the release channel variable in .environment to stable, when the user uses the stable flag so that updater is automatically pulling stable releases, then it makes sense to add the option. But to make it complete we will need to add handling on the other side too (makeself installer).

If we agree that we do not want to automatically force the stable release channel on the static install, as it was the initial decision with @cakrit when we fixed the updater to work for the static install, then indeed no need to add it to inner opts

paulkatsoulakis · 2019-10-10T19:01:35Z

Also @paulkatsoulakis please ensure that @knatsakis knows how to update the two scripts, once the PR is merged.

Hello, We 've already discussed the details with @knatsakis earlier today, but feel free to ping me should you need more help or documentation

knatsakis · 2019-10-10T21:12:22Z

packaging/installer/kickstart.sh

@@ -307,6 +307,7 @@ while [ -n "${1}" ]; do
 		shift 1
 	elif [ "${1}" = "--stable-channel" ]; then
 		RELEASE_CHANNEL="stable"
+		NETDATA_INSTALLER_OPTIONS="$NETDATA_INSTALLER_OPTIONS --stable-channel"


Could you make this so that it doesn't add an extra space when $NETDATA_INSTALLER_OPTIONS is empty?

This is harmless in bash and spaces are collapsed. I don't think it justifies the extra fluff. Also, https://github.com/netdata/netdata/blob/master/packaging/installer/kickstart-static64.sh#L193 seems to do the same.

knatsakis · 2019-10-10T21:13:11Z

packaging/installer/kickstart.sh

@@ -351,7 +352,7 @@ done

 if [ "${INTERACTIVE}" = "0" ]; then
 	PACKAGES_INSTALLER_OPTIONS="--dont-wait --non-interactive ${PACKAGES_INSTALLER_OPTIONS}"
-	NETDATA_INSTALLER_OPTIONS="--dont-wait"
+	NETDATA_INSTALLER_OPTIONS="$NETDATA_INSTALLER_OPTIONS --dont-wait"


The same here: could you make this so that it doesn't add an extra space when $NETDATA_INSTALLER_OPTIONS is empty?

See my other comment

oxplot · 2019-10-11T06:43:13Z

are we happy to leave changes to static64 to another PR?

knatsakis · 2019-10-13T18:06:18Z

are we happy to leave changes to static64 to another PR?

Yes, please leave changes to static64 to another PR.
Kindly undo those changes so that I can merge this PR.

This reverts commit 678ebba.

* kickstart: pass options to installer - pass --stable-channel option - append --dont-wait option to list of passthrough options * kickstart: passthrough --stable-channel in static64 * kickstart: update checksums in readme * Revert "kickstart: passthrough --stable-channel in static64" This reverts commit 678ebba. * Revert kickstart-static64 checksum update

kickstart: pass options to installer

42142c7

- pass --stable-channel option - append --dont-wait option to list of passthrough options

oxplot requested review from cakrit, cosmix and knatsakis as code owners October 10, 2019 11:53

oxplot mentioned this pull request Oct 10, 2019

--stable-channel option not working #7040

Closed

netdatabot added the area/packaging Packaging and operating systems support label Oct 10, 2019

cosmix suggested changes Oct 10, 2019

View reviewed changes

oxplot added 2 commits October 11, 2019 03:07

kickstart: passthrough --stable-channel in static64

678ebba

kickstart: update checksums in readme

320534f

oxplot requested a review from joelhans as a code owner October 10, 2019 16:07

knatsakis reviewed Oct 10, 2019

View reviewed changes

netdatabot added the area/docs label Oct 10, 2019

knatsakis suggested changes Oct 10, 2019

View reviewed changes

oxplot added 2 commits October 14, 2019 09:56

Revert "kickstart: passthrough --stable-channel in static64"

4262c7d

This reverts commit 678ebba.

Revert kickstart-static64 checksum update

1c08674

cakrit approved these changes Oct 14, 2019

View reviewed changes

knatsakis self-requested a review October 15, 2019 13:38

knatsakis approved these changes Oct 15, 2019

View reviewed changes

knatsakis merged commit e66165b into netdata:master Oct 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kickstart: pass options to installer #7051

kickstart: pass options to installer #7051

oxplot commented Oct 10, 2019

squash-labs bot commented Oct 10, 2019

cosmix left a comment •

edited

Loading

paulkatsoulakis commented Oct 10, 2019

cakrit commented Oct 10, 2019

knatsakis commented Oct 10, 2019 •

edited

Loading

CLAassistant commented Oct 10, 2019 •

edited

Loading

ilyam8 commented Oct 10, 2019

knatsakis Oct 10, 2019

oxplot Oct 11, 2019

paulkatsoulakis Oct 12, 2019

paulkatsoulakis commented Oct 10, 2019 •

edited

Loading

knatsakis Oct 10, 2019

oxplot Oct 11, 2019

knatsakis Oct 10, 2019 •

edited

Loading

oxplot Oct 11, 2019

oxplot commented Oct 11, 2019

knatsakis commented Oct 13, 2019

kickstart: pass options to installer #7051

kickstart: pass options to installer #7051

Conversation

oxplot commented Oct 10, 2019

Summary

Component Name

Additional Information

squash-labs bot commented Oct 10, 2019

Manage this branch in Squash

cosmix left a comment • edited Loading

Choose a reason for hiding this comment

paulkatsoulakis commented Oct 10, 2019

cakrit commented Oct 10, 2019

knatsakis commented Oct 10, 2019 • edited Loading

CLAassistant commented Oct 10, 2019 • edited Loading

ilyam8 commented Oct 10, 2019

knatsakis Oct 10, 2019

Choose a reason for hiding this comment

oxplot Oct 11, 2019

Choose a reason for hiding this comment

paulkatsoulakis Oct 12, 2019

Choose a reason for hiding this comment

paulkatsoulakis commented Oct 10, 2019 • edited Loading

knatsakis Oct 10, 2019

Choose a reason for hiding this comment

oxplot Oct 11, 2019

Choose a reason for hiding this comment

knatsakis Oct 10, 2019 • edited Loading

Choose a reason for hiding this comment

oxplot Oct 11, 2019

Choose a reason for hiding this comment

oxplot commented Oct 11, 2019

knatsakis commented Oct 13, 2019

cosmix left a comment •

edited

Loading

knatsakis commented Oct 10, 2019 •

edited

Loading

CLAassistant commented Oct 10, 2019 •

edited

Loading

paulkatsoulakis commented Oct 10, 2019 •

edited

Loading

knatsakis Oct 10, 2019 •

edited

Loading