Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbengine consistency #6979

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Fix dbengine consistency #6979

merged 1 commit into from
Oct 2, 2019

Conversation

mfundul
Copy link
Contributor

@mfundul mfundul commented Oct 1, 2019

Summary

Fix dbengine consistency when a writer modifies a page concurrently with a reader querying its metrics.

Component Name

database/engine

Additional Information

Fixes #6978

@squash-labs
Copy link

squash-labs bot commented Oct 1, 2019

Manage this branch in Squash

Test this branch here: https://mfundulconsistent-query-during-18vo2.squash.io

Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After to run during more than 8 hours the tests listed below:

  • Compilation with clang without errors (BSD only)
  • I let Netdata running alone with few servers in parallel to confirm that everything was running correctly in this situation
  • Finally I ran a stress test on Netdata and Apache

these tests were executed on Slackware Current and FreeBSD 12-p10 and everything worked without errors.

@mfundul mfundul merged commit 1d667b1 into netdata:master Oct 2, 2019
@mfundul mfundul deleted the consistent-query-during-metric-update branch October 2, 2019 04:12
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request Oct 9, 2019
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying latest metrics is not always consistent
3 participants