Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus version update #6652

Merged
merged 5 commits into from
Aug 14, 2019
Merged

Prometheus version update #6652

merged 5 commits into from
Aug 14, 2019

Conversation

prhomhyse
Copy link
Contributor

Summary

Fixes #6630

This PR updates the version of Prometheus in the documentation and also fixes some markdown lint warnings.

Component Name

doc

Additional Information

Copy link
Contributor

@cakrit cakrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mention of version 1.7.1 in the prometheus output later in the file.
Can't you please just make the instructions so that we don't mention the version anywhere?

@joelhans
Copy link
Contributor

I wonder if we can use one of these one-liners to always download the latest version of the package that begins with prometheus and ends with linux-amd64.tar.gz:

https://gist.github.com/steinwaywhw/a4cd19cda655b8249d908261a62687f8

5 minutes of experimenting led nowhere for me, but if you can figure it out, that'll help make the article version-agnostic.

@prhomhyse
Copy link
Contributor Author

@cakrit
I have removed the mention of versions in both files
Thanks for the tip @joelhans
I have figured it out and added it to both files.

And as expected your other PR conflicted and thankfully, it was just one of the files 😅

@joelhans joelhans merged commit 398fdc4 into netdata:master Aug 14, 2019
@prhomhyse prhomhyse deleted the prometheus branch August 15, 2019 21:53
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
* fix prometheus version download link

* fix prometheus version and few lint warnings

* remove specific version of prometheus

* remove prometheus versions and some minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus documentation version update
4 participants