fix(providers): serialize tool calls and tool results in conversation history#210
Merged
Aaronontheweb merged 2 commits intoMar 13, 2026
Merged
Conversation
… history ToMessage() was dropping tool_calls from assistant messages and tool_call_id from tool result messages, sending only role+content for all non-system messages. This caused multi-turn tool calling to fail because the LLM could not correlate tool results back to calls in the conversation history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAiCompatibleChatClient.ToMessage()was serializing all non-system messages as simple{"role": "...", "content": "..."}objects, droppingtool_callsfrom assistant messages andtool_call_idfrom tool result messagesFunctionCallContent(emitstool_callsarray) and tool result messages withFunctionResultContent(emitstool_call_id)Test plan
SerializesAssistantToolCalls_AndToolResults_InConversationHistoryverifies correct payload structureOpenAiCompatibleChatClientTestspassnetclaw -p