Add bounded output continuation contracts - #2038
Merged
Aaronontheweb merged 1 commit intoAug 20, 2026
Merged
Conversation
Comment on lines
+55
to
+61
| foreach (var value in callId) | ||
| { | ||
| if (char.IsControl(value) | ||
| || char.IsWhiteSpace(value) | ||
| || value is '/' or '\\') | ||
| return false; | ||
| } |
Comment on lines
+135
to
+143
| foreach (var attribute in attributes) | ||
| { | ||
| if (attribute.AttributeClass?.Name == "DescriptionAttribute" | ||
| && attribute.ConstructorArguments.Length > 0 | ||
| && attribute.ConstructorArguments[0].Value is string description) | ||
| { | ||
| return description; | ||
| } | ||
| } |
Comment on lines
+240
to
+259
| foreach (var argument in attribute.NamedArguments) | ||
| { | ||
| if (argument.Key != name || argument.Value.Kind != TypedConstantKind.Array) | ||
| continue; | ||
|
|
||
| var result = ImmutableArray.CreateBuilder<string>(argument.Value.Values.Length); | ||
| foreach (var value in argument.Value.Values) | ||
| { | ||
| if (value.Value is not string parameterName) | ||
| { | ||
| values = []; | ||
| return false; | ||
| } | ||
|
|
||
| result.Add(parameterName); | ||
| } | ||
|
|
||
| values = result.MoveToImmutable(); | ||
| return true; | ||
| } |
|
|
||
| try | ||
| { | ||
| directory = Path.GetFullPath(Path.Combine(sessionDirectory!, ToolCallsSubdirectory)); |
| { | ||
| directory = Path.GetFullPath(Path.Combine(sessionDirectory!, ToolCallsSubdirectory)); | ||
| var fileName = Convert.ToHexString(SHA256.HashData(Encoding.UTF8.GetBytes(callId!))) + ".log"; | ||
| path = Path.GetFullPath(Path.Combine(directory, fileName)); |
Collaborator
Author
|
Sanitized hosted follow-up from the completed top-of-stack rollout proof (#2039): the spilled-output continuation scenario passed 0/5. All five trials used shell, one searched the tool catalog, and none loaded or called tool_output_read. The deterministic spill contract tests remain green; this result identifies a remaining discoverability and agent-selection problem. The assertion was not weakened. Raw transcripts and environment details are not published. |
Aaronontheweb
force-pushed
the
goal/pit-of-success-output-contracts
branch
from
August 20, 2026 07:14
dcbfcbf to
609355b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_output_readtool for bounded continuation of a truncated result.oneOfschemas for reminder delivery and skill management modes.Security
Validation
Eval evidence
complex_large_shell_output_spillcase now requires bothshell_executeandtool_output_read.