Make workspace tool outcomes authoritative - #2033
Merged
Aaronontheweb merged 2 commits intoAug 20, 2026
Merged
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| Assert.True(ok); | ||
| Assert.Equal("src/Rect.cs", path); | ||
| } | ||
| var first = Path.GetFullPath(Path.Combine(Path.GetTempPath(), "receipt-first.txt")); |
| Assert.Equal("src/Rect.cs", path); | ||
| } | ||
| var first = Path.GetFullPath(Path.Combine(Path.GetTempPath(), "receipt-first.txt")); | ||
| var second = Path.GetFullPath(Path.Combine(Path.GetTempPath(), "receipt-second.txt")); |
|
|
||
| Assert.True(outputs.TryComplete(new ToolInvocationReceipt(ToolInvocationOutcomeCategory.AccessDenied))); | ||
| Assert.False(outputs.TryComplete(Success( | ||
| Path.GetFullPath(Path.Combine(Path.GetTempPath(), "late.txt")), |
| Content = "..." | ||
| } | ||
| }; | ||
| var path = Path.GetFullPath(Path.Combine(Path.GetTempPath(), "invalid.txt")); |
| [Fact] | ||
| public async Task Denied_write_reports_no_file_activity() | ||
| { | ||
| var filePath = Path.Combine(_dir.Path, "denied.txt"); |
Aaronontheweb
force-pushed
the
goal/pit-of-success-workspace-paths
branch
from
August 20, 2026 04:50
ff22127 to
30ff8cb
Compare
Aaronontheweb
force-pushed
the
goal/pit-of-success-workspace-paths
branch
from
August 20, 2026 05:33
30ff8cb to
8477814
Compare
Comment on lines
+384
to
+387
| var missingPath = Path.Combine( | ||
| Path.GetTempPath(), | ||
| "netclaw-missing-" + Guid.NewGuid().ToString("N"), | ||
| "file.txt"); |
| var publicContext = CreateContext(TrustAudience.Public); | ||
|
|
||
| var allowed = policy.TryResolveWritePath("/some/path", publicContext, out _, out var error); | ||
| var path = Path.Combine(Path.GetTempPath(), "netclaw-public-denied.txt"); |
Aaronontheweb
added
enhancement
This was referenced Aug 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 4 of the make-agent-tools-pit-of-success stack.
Deterministic evaluation evidence
Validation