Skip to content

Stop scope retries after shell access denial - #1985

Merged
Aaronontheweb merged 1 commit into
devfrom
goal/reduce-fresh-session-approval-spam-completion
Aug 18, 2026
Merged

Stop scope retries after shell access denial#1985
Aaronontheweb merged 1 commit into
devfrom
goal/reduce-fresh-session-approval-spam-completion

Conversation

@Aaronontheweb

Copy link
Copy Markdown
Collaborator

Summary

  • Stop inherited guidance from treating a terminal access denial as a scope correction.
  • Preserve one unchanged retry only for a deferred shell result.
  • Lock sanitized live evidence and the same-model 15-run result.

Validation

  • Release build: 0 warnings and 0 errors.
  • Full tests: 7,532 passed with 15 expected skips.
  • Focused prompt tests: 24 passed.
  • Focused evidence and PII tests: 73 passed.
  • DeepSeek evals: 15 of 15 behavior passes.
  • Strict OpenSpec, headers, JSON, Bash syntax, diff, and changed-file format checks passed.
  • Slopwatch found only the unchanged timeout-test warning from 8682049.

@Aaronontheweb Aaronontheweb added the shell Issues related to the shell tool, since it has the largest security perimeter. label Aug 18, 2026
@Aaronontheweb
Aaronontheweb force-pushed the goal/reduce-fresh-session-approval-spam-completion branch from e3e1f65 to 0087f64 Compare August 18, 2026 13:31
@Aaronontheweb

Copy link
Copy Markdown
Collaborator Author

Ubuntu exposed an unrelated startup-order race in ReminderManagerActorTests: ActorOf can return before PreStart queues its self-reconcile, so one Ask was not a deterministic startup barrier.

The test-only correction uses two ordered reconcile barriers, matching the established actor-start ordering. No assertion or production behavior was relaxed. Validation: four affected tests 4/4, target test 30/30 repeated, full Actors suite 3,430 passed with one expected Windows-only skip, formatting/headers/diff check clean, and Slopwatch reports only the unchanged pre-existing SW004 in PowerShellHostProbeTests.cs:311.

@Aaronontheweb
Aaronontheweb force-pushed the goal/reduce-fresh-session-approval-spam-completion branch from 0087f64 to e657549 Compare August 18, 2026 14:06
@Aaronontheweb
Aaronontheweb merged commit 00d93eb into dev Aug 18, 2026
23 checks passed
@Aaronontheweb
Aaronontheweb deleted the goal/reduce-fresh-session-approval-spam-completion branch August 18, 2026 14:36
@Aaronontheweb Aaronontheweb mentioned this pull request Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shell Issues related to the shell tool, since it has the largest security perimeter.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant