Skip to content

Collapse shell policy phase machinery - #1965

Merged
Aaronontheweb merged 1 commit into
devfrom
refactor/simplify-shell-direct-evaluation-7
Aug 15, 2026
Merged

Collapse shell policy phase machinery#1965
Aaronontheweb merged 1 commit into
devfrom
refactor/simplify-shell-direct-evaluation-7

Conversation

@Aaronontheweb

Copy link
Copy Markdown
Collaborator

Summary

  • replace the internal stage-result hierarchy, terminal-state machine, and separate stage-owner classes with one direct coordinator method
  • preserve the same ten authorization phases, ordering, cancellation checks, actor-evidence boundary, coverage, and trace semantics
  • replace 1,664 lines of production-impossible stage tests with focused path-fact and atomic-state regressions plus an end-to-end actor-cancellation regression
  • remove 254 production lines and 16 control-flow lines; cumulative policy control-flow is now below the frozen baseline

Verification

  • Netclaw.Security.Tests: 946 passed
  • Netclaw.Actors.Tests: 3,396 passed; one expected Windows-only skip
  • coordinator/fixture/disposition replay: 420 passed
  • security evidence contract: 26 passed
  • channel/recovery/headless/subagent focus: 279 passed
  • strict validation passes for both active shell-policy OpenSpec changes
  • headers, changed-file formatting, diff check, and changed-file Slopwatch pass

@Aaronontheweb
Aaronontheweb enabled auto-merge (squash) August 15, 2026 01:23
[candidate],
ShellPathStyle.Posix));

Assert.Equal("/work/sub", facts.RealScope.Path?.Value);
ShellPathStyle.Posix));

Assert.Equal("/work/sub", facts.RealScope.Path?.Value);
Assert.Equal("/work", facts.Real.ResolutionBase.Path?.Value);
[candidate],
ShellPathStyle.Posix));

Assert.Equal("/tmp", facts.Intent?.ResolutionBase.Path?.Value);
@Aaronontheweb
Aaronontheweb merged commit bbecae3 into dev Aug 15, 2026
23 checks passed
@Aaronontheweb
Aaronontheweb deleted the refactor/simplify-shell-direct-evaluation-7 branch August 15, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant