Add typed shell policy coordinator - #1916
Merged
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
August 13, 2026 05:48
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+34
to
+37
| catch (Exception) | ||
| { | ||
| return ToolAuthorizationDecision.Deny("internal_policy_failure"); | ||
| } |
Comment on lines
+129
to
+142
| foreach (var candidate in grantCandidates.Where(candidate => | ||
| coverage.UncoveredIds.Contains(candidate.Id))) | ||
| { | ||
| if (policy.IsReviewedSafeCandidate( | ||
| candidate.Candidate, | ||
| projection.ApprovalContext.Cwd, | ||
| context.Invocation)) | ||
| { | ||
| coverage.Cover( | ||
| candidate.Id, | ||
| ShellCoverageKind.ReviewedSafePolicy, | ||
| ShellPolicyReason.ReviewedSafePhrase); | ||
| } | ||
| } |
Comment on lines
+176
to
+187
| foreach (var candidate in candidates) | ||
| { | ||
| if (!_coverage.TryAdd( | ||
| candidate.Id, | ||
| new ShellCandidateCoverage( | ||
| candidate.Id, | ||
| ShellCoverageKind.Uncovered, | ||
| ShellPolicyReason.None))) | ||
| { | ||
| throw new InvalidOperationException("Duplicate shell candidate id."); | ||
| } | ||
| } |
Comment on lines
+256
to
+266
| foreach (var entry in persistedApprovals) | ||
| { | ||
| if (!ApprovalPatternMatching.MatchesShellApproval(candidate, cwd, [entry])) | ||
| continue; | ||
|
|
||
| return new ShellActorGrantMatch( | ||
| new ToolApprovalMatch(candidate.Verb, "persistent", entry.FormatScope()), | ||
| entry.Directory is null | ||
| ? ShellCoverageKind.PersistentGlobal | ||
| : ShellCoverageKind.PersistentFolder); | ||
| } |
| [Fact(SkipUnless = nameof(IsPosix), Skip = "POSIX-only shell coverage semantics")] | ||
| public async Task Authorization_evaluation_composes_session_and_reviewed_safe_coverage() | ||
| { | ||
| var root = Path.Combine(Path.GetTempPath(), $"netclaw-coverage-{Guid.NewGuid():N}"); |
Aaronontheweb
added
the
shell
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This slice replaces the split shell approval path with one explicit coverage model. ShellSyntaxTree remains the source of syntax facts; Netclaw remains the owner of trust, scope, and final authority. The new internal seam supports later policy stages without more dispatcher branches or executable-specific command parsers.
No public API changes are part of this pull request.
Validation