Skip to content

Allow unknown Bash argument data - #1875

Merged
Aaronontheweb merged 1 commit into
devfrom
fix/general-shell-approval-analysis
Aug 12, 2026
Merged

Allow unknown Bash argument data#1875
Aaronontheweb merged 1 commit into
devfrom
fix/general-shell-approval-analysis

Conversation

@Aaronontheweb

Copy link
Copy Markdown
Collaborator

Summary

  • treat unresolved Bash parameter expansion as structurally safe only after ShellSyntaxTree classifies it as a non-path argument
  • keep dynamic command identities, paths, redirects, substitutions, and command-string execution fail closed
  • cover the sanitized gh run view ... | head; echo "$?" diagnostic in focused and approval-matrix tests

This is deliberately syntax-general. It adds no executable, subcommand, option, or operand-specific approval parsing.

Validation

  • focused ShellCommandAnalysis and ShellApprovalMatcher tests: 141 passed
  • full Security suite: 841 passed
  • full solution suite passed locally (one expected Windows-only skip)
  • copyright headers verified
  • Slopwatch: 0 issues
  • adversarial review: PASS
  • sanitized case scan: no PII

@Aaronontheweb
Aaronontheweb enabled auto-merge (squash) August 11, 2026 16:28
@Aaronontheweb Aaronontheweb added shell Issues related to the shell tool, since it has the largest security perimeter. UX/DX UI / UX / DX friction issue or user-facing annoyances. labels Aug 11, 2026
@Aaronontheweb
Aaronontheweb disabled auto-merge August 11, 2026 16:49
@Aaronontheweb
Aaronontheweb force-pushed the fix/general-shell-approval-analysis branch from b7a80b4 to a18a477 Compare August 12, 2026 00:20
@Aaronontheweb
Aaronontheweb enabled auto-merge (squash) August 12, 2026 00:20
@Aaronontheweb
Aaronontheweb disabled auto-merge August 12, 2026 00:31
@Aaronontheweb
Aaronontheweb merged commit 471af61 into dev Aug 12, 2026
23 checks passed
@Aaronontheweb
Aaronontheweb deleted the fix/general-shell-approval-analysis branch August 12, 2026 00:31
@Aaronontheweb Aaronontheweb mentioned this pull request Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shell Issues related to the shell tool, since it has the largest security perimeter. UX/DX UI / UX / DX friction issue or user-facing annoyances.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant