refactor(reminders): use IWithTimers for execution backstops - #1822
Merged
Conversation
Replace both Context.System.Scheduler.ScheduleTellOnceCancelable one-shot timers (execution attempt timeout, delivery-observed backstop) with the actor's injected ITimerScheduler via IWithTimers: - StartSingleTimer arms each backstop; distinct timer keys keep them independent. - Timers.Cancel replaces the manual ICancelable cancellation on the delivery-observed and settlement paths. - IWithTimers cancels timers automatically on actor stop, so the PostStop bookkeeping for the two ICancelable fields is gone entirely. No behavioral change: same messages, same delays (ExecutionAttemptTimeout, DeliveryObservedTimeout). 173 reminder tests green; slopwatch 0; headers clean.
Aaronontheweb
added
reminders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
ReminderExecutionActoroffContext.System.SchedulertoIWithTimers— same rule applied to PR #1821.Change
Both one-shot scheduler timers become
Timers.StartSingleTimerwith distinct keys:ExecutionAttemptTimeoutReached) — armed inPreStartDeliveryBackstopTimeout) — armed inBeginAwaitingDeliveryResultTimers.Cancelreplaces the manualICancelablecancellation on the delivery-observed and settlement paths.IWithTimerscancels timers automatically on actor stop, so thePostStopbookkeeping for bothICancelablefields is deleted.Why
ExecutionStarteddead-letter class of noise).ICancelablenull-tracking; less bookkeeping, no leak path.ITimerScheduler.Verification
No behavioral change: same messages, same delays (
ExecutionAttemptTimeout,DeliveryObservedTimeout). 173 reminder tests green; slopwatch 0; headers clean.