fix(tui): Escape is a no-op at root; Ctrl+Q is the only quit key - #1765
Merged
Conversation
Fixes #1764. Escape used to call Shutdown() or RequestQuit() at the root of seven TUI pages, so one stray tap killed the app. It is now a no-op at every root; Ctrl+Q is the only quit path. Pages fixed: session picker, stats, config dashboard, init wizard, provider manager, model manager, and reminder create. Plain Q no longer quits stats (Ctrl+Q only). Footers updated to stop advertising Esc as a quit key and StatsViewModel no longer advertises [Q] Quit.
Native Smoke (Linux) failed because sessions-tui.tape pressed Escape to quit the sessions picker — exactly the behavior #1764 removes. Switch the tape to Ctrl+Q, the only quit key. Screenshot Regression failed because the standalone provider manager footer no longer advertises [Esc] Quit; refresh the approved baseline.
Aaronontheweb
commented
Aug 5, 2026
Aaronontheweb
left a comment
Aaronontheweb
left a comment
Collaborator
Author
There was a problem hiding this comment.
Removed escape key and standardized all netclaw TUIs on Control + Q to quit. Control + C will also still work of course.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1764.
Problem: Escape called
Shutdown()/RequestQuit()at the root of seven TUI pages, so one stray Escape tap killed the app. PR #1760 established the convention for the chat page: Escape is a pure cancel key, Ctrl+Q is the only quit.Offenders fixed:
SessionsViewModel.HandleKey— session picker root (first screen)StatsViewModel.HandleKeyPress— plainQ,Escape, andCtrl+Call quit; now only Ctrl+QConfigDashboardPage.HandleKeyPress— dashboard rootInitWizardPage.HandleKeyPress— wizard root (GoBack()false → quit removed)ProviderManagerViewModel.GoBack— standalonenetclaw providerrootModelManagerViewModel.GoBack— standalonenetclaw modelroot (same pattern, missed by the issue)ReminderCreateViewModel.GoBack—TitleandDonestates (same pattern, missed by the issue)Footers updated so the UI stops advertising Escape (or plain Q) as a quit key:
ConfigDashboardPage— removed[Esc] QuitInitWizardPage— root no longer shows[Esc] Quit; non-root keeps[Esc] BackModelManagerPage/ProviderManagerPage— standalone footer no longer shows[Esc] QuitStatsViewModel—[Q] Quit→[Ctrl+Q] QuitReminderCreatePage—Title/Doneno longer show[Esc] QuitTests: 3 new page-level regression tests (sessions picker, init wizard, provider manager) prove Escape no longer kills the app and subsequent keys still work. Full TUI suite (714 tests) green. Slopwatch clean, headers verified.