ci: run PR validation for feature/* base branches - #1586
Merged
Aaronontheweb merged 1 commit intoJul 5, 2026
Conversation
Add `feature/*` to PR-validation workflow base-branch filters. GitHub's pull_request and push branches filters match the BASE branch and branch head, respectively. Without explicit `feature/*` filters, PRs targeting `feature/*` branches (e.g., `feature/memory-embeddings`) were skipping full CI validation. This change enables the embedding stack and future feature branches to run full validation on their own PRs while maintaining the current dev/master/main flow. Release and publish workflows are unchanged. Workflows modified: - pr_validation.yml: added feature/* to push and pull_request - smoke.yml: added feature/* to push and pull_request - validate_docker_image.yml: added feature/* to push and pull_request (with existing paths filter) Workflows skipped (unchanged): - demo_smoke.yml: workflow_dispatch only (manual trigger) - publish_release_binaries.yml: tag-triggered release workflow - publish_skills.yml: workflow_call + workflow_dispatch (publishing) - website-rebuild.yml: release-triggered (publishing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
feature/*base-branch support to PR-validation workflows so feature branches (e.g.feature/memory-embeddings) run full CI validation on their own PRs.GitHub's
pull_requestandpushbranch filters match the base branch and branch head respectively. Without explicitfeature/*entries, feature-targeted PRs were skipping validation.Workflows Modified
feature/*feature/*feature/*Workflows Unchanged
YAML Validation
All modified workflows pass Python yaml.safe_load() validation.