Skip to content

test(tools): block system and external skill file mutations #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 1 commit into from
Jun 22, 2026
Merged

test(tools): block system and external skill file mutations #1457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 137 additions & 0 deletions src/Netclaw.Actors.Tests/Tools/SkillToolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,74 @@ public async Task SkillManage_WriteFile_RejectsHighRiskResourceContent()
Assert.False(File.Exists(Path.Combine(_paths.SkillsDirectory, "wf-test", "references", "guide.md")));
}

[Fact]
public async Task SkillManage_WriteFile_RejectsSystemSkill()
{
WriteNestedSkill(".system", "sys-wf", """
---
name: sys-wf
description: System skill.
---

# System
""");
ScanSkills();

var tool = CreateManageTool();
var result = await tool.ExecuteAsync(ToolInput.Create(
"Action", "write_file",
"Name", "sys-wf",
"FilePath", "references/guide.md",
"FileContent", "content"),
PersonalCtx,
TestContext.Current.CancellationToken);

Assert.Contains("System skills are read-only", result);

var expected = Path.Combine(_paths.SkillsDirectory, ".system", "sys-wf", "references", "guide.md");
Assert.False(File.Exists(expected));
}

[Fact]
public async Task SkillManage_WriteFile_RejectsExternalSkill()
{
var externalDir = Path.Combine(Path.GetTempPath(), $"netclaw-external-test-{Guid.NewGuid():N}");
try
{
var skillDir = Path.Combine(externalDir, "ext-wf");
Directory.CreateDirectory(skillDir);
File.WriteAllText(Path.Combine(skillDir, "SKILL.md"), """
---
name: ext-wf
description: External skill.
---

# External
""");

var externalScan = SkillScanner.Scan(externalDir);
_registry.ReplaceAll(externalScan.AcceptedSkills, externalScan.Issues);

var tool = CreateManageTool();
var result = await tool.ExecuteAsync(ToolInput.Create(
"Action", "write_file",
"Name", "ext-wf",
"FilePath", "references/guide.md",
"FileContent", "content"),
PersonalCtx,
TestContext.Current.CancellationToken);

Assert.Contains("External skill directories are read-only", result);
var target = Path.Combine(externalDir, "ext-wf", "references", "guide.md");
Assert.False(File.Exists(target));
}
finally
{
if (Directory.Exists(externalDir))
Directory.Delete(externalDir, recursive: true);
}
}

[Fact]
public async Task SkillManage_Patch_RejectsHighRiskResourceContent()
{
Expand Down Expand Up @@ -558,6 +626,75 @@ public async Task SkillManage_Patch_RejectsHighRiskResourceContent()
Assert.DoesNotContain("Ignore previous instructions", content);
}

[Fact]
public async Task SkillManage_RemoveFile_RejectsSystemSkill()
{
WriteNestedSkill(".system", "sys-remove", """
---
name: sys-remove
description: System skill.
---

# System
""");

WriteNestedFile(".system", "sys-remove", "references/old.md", "old");
ScanSkills();

var tool = CreateManageTool();
var result = await tool.ExecuteAsync(ToolInput.Create(
"Action", "remove_file",
"Name", "sys-remove",
"FilePath", "references/old.md"),
PersonalCtx,
TestContext.Current.CancellationToken);

Assert.Contains("System skills are read-only", result);
Assert.True(File.Exists(Path.Combine(_paths.SkillsDirectory, ".system", "sys-remove", "references", "old.md")));
}

[Fact]
public async Task SkillManage_RemoveFile_RejectsExternalSkill()
{
var externalDir = Path.Combine(Path.GetTempPath(), $"netclaw-external-test-{Guid.NewGuid():N}");
try
{
var skillDir = Path.Combine(externalDir, "ext-remove");
Directory.CreateDirectory(skillDir);
File.WriteAllText(Path.Combine(skillDir, "SKILL.md"), """
---
name: ext-remove
description: External skill.
---

# External
""");

Directory.CreateDirectory(Path.Combine(skillDir, "references"));
File.WriteAllText(Path.Combine(skillDir, "references", "old.md"), "old");

var externalScan = SkillScanner.Scan(externalDir);
_registry.ReplaceAll(externalScan.AcceptedSkills, externalScan.Issues);

var tool = CreateManageTool();
var result = await tool.ExecuteAsync(ToolInput.Create(
"Action", "remove_file",
"Name", "ext-remove",
"FilePath", "references/old.md"),
PersonalCtx,
TestContext.Current.CancellationToken);

Assert.Contains("External skill directories are read-only", result);
Assert.True(Directory.Exists(skillDir));
Assert.True(File.Exists(Path.Combine(skillDir, "references", "old.md")));
}
finally
{
if (Directory.Exists(externalDir))
Directory.Delete(externalDir, recursive: true);
}
}

[Fact]
public async Task SkillManage_Delete_RemovesSkillDirectory()
{
Expand Down
Loading