Skip to content

Fixes #20398: Rely on browser-native form field validation #20401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

Fixes #20398: Rely on browser-native form field validation #20401

merged 1 commit into from
Sep 19, 2025

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Sep 19, 2025

Fixes: #20398

  • Remove the TypeScript which applies the is-invalid CSS class to form fields with invalid values on form submit
  • Remove the call to event.preventDefault() to allow the native browser validation to take over
  • Remove the now-obsolete generic "This field is required" warning from the form template

@jeremystretch jeremystretch requested review from a team and jnovinger and removed request for a team September 19, 2025 19:42
jnovinger
jnovinger approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@jnovinger jnovinger merged commit 6547a16 into main Sep 19, 2025
10 checks passed
@jnovinger jnovinger deleted the 20398-foem-field-validation branch September 19, 2025 20:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jnovinger jnovinger jnovinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Min/max validation failures for numeric fields is misleading

3 participants

@jeremystretch @jnovinger