Closes #19547: Add Sync button for DataSource ListView #20269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pheus
force-pushed
the
19547-add-sync-button-to-data-source-list-view
branch
from
8d32ec1 to
3b4894c
Compare
jeremystretch
requested review from
a team and
jeremystretch
and removed request for
a team
jeremystretch
requested changes
Sep 5, 2025
Introduces a sync button in the DataSource table for improved user interaction. Enables users to trigger sync actions directly from the table, with context-sensitive availability based on permissions and record status. Closes netbox-community#19547
pheus
force-pushed
the
19547-add-sync-button-to-data-source-list-view
branch
from
3b4894c to
29ba9cb
Compare
| _("Queued job #{id} to sync {datasource}").format(id=job.pk, datasource=datasource) | ||
| ) | ||
| return redirect(datasource.get_absolute_url()) | ||
| return redirect(self.get_return_url(request, datasource)) |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
|
Thank you for taking the time to review this PR. I appreciate the thoughtful feedback and attention to detail. |
jeremystretch
approved these changes
Sep 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19547
Summary
Adds a Sync button to the Data Sources list view so a sync can be triggered directly from the table (no need to open the detail page).
Details
UX
Notes
Open to feedback on approach.