FIX #18154 - Cannot change default table preferences for anonymous users #18544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
reviewed
Jan 30, 2025
netbox/netbox/tables/tables.py
Outdated
| @@ -64,6 +66,11 @@ def __init__(self, *args, user=None, **kwargs): | |||
| selected_columns = None | |||
| if user is not None and not isinstance(user, AnonymousUser): | |||
| selected_columns = user.config.get(f"tables.{self.name}.columns") | |||
| elif isinstance(user, AnonymousUser) and hasattr(settings, 'DEFAULT_USER_PREFERENCES'): | |||
| default_user_preferences = settings.DEFAULT_USER_PREFERENCES | |||
| default_table = default_user_preferences.get('tables', {}).get(self.name, {}).get('columns', {}) | |||
There was a problem hiding this comment.
Could probably simplify this to
selected_columns = settings.DEFAULT_USER_PREFERENCES.get('tables', {}).get(self.name, {}).get('columns')
Right? Or is there some logical case I'm missing?
There was a problem hiding this comment.
We still need to check is settings have DEFAULT_USER_PREFERENCES attribute, my first implementation I've missed that test and a lot of unit testa fails because the DEFAULT_USER_PREFERENCES aren't a required configuration.
But the next parts is definitely simpler, gonna change to that format.
bctiemann
reviewed
Jan 31, 2025
netbox/netbox/tables/tables.py
Outdated
| @@ -13,6 +14,7 @@ | |||
| from django.utils.translation import gettext_lazy as _ | |||
| from django_tables2.data import TableQuerysetData | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This extra line should be removed
bctiemann
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18154