Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk delete from IP Address List - Possible Permissions Issue #845

Closed
specialcircumstances opened this issue Jan 25, 2017 · 1 comment
Closed
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@specialcircumstances
Copy link

Assuming a normal user (not staff or superuser) has add, delete, change permissions for devices and ip addresses.

When the user selects multiple IP Addresses in the IP Address list, the bulk Delete button does not appear.

A superuser can do this fine. I don't think this is intended?

I think this happens in obj_table.html somwhere around here:

{% if bulk_delete_url and table.model|user_can_delete:request.user %}

So, assuming the bulk_delete_url is passed correctly from the view, I'm guessing it's something to do with the evaluation of table.model|user_can_delete:request.user but that's as far as I've been able to get.

Hope that's some help?

@jeremystretch jeremystretch added the type: bug A confirmed report of unexpected behavior in the application label Jan 26, 2017
@jeremystretch
Copy link
Member

It seems like table.model is no longer returning the associate model. Not sure why; could have been a change in django-tables2. At any rate, I'm going to rewrite they way permissions are checked for table rendering.

lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants