Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add age column and fix column order #81

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add age column and fix column order #81

merged 1 commit into from
Oct 1, 2024

Conversation

jstudler
Copy link
Contributor

@jstudler jstudler commented Oct 1, 2024

A few UX changes:

  • Adds an age column (with Kubebuilder this disappears from the CRD as soon as you add the first printcolumn)
  • Orders the condition columns to feature the "Ready" condition as the last one

Before:

kubectl get ipc
NAME                    IPADDRESS    READY   IPASSIGNED
ipaddressclaim-sample   2.0.0.1/32   True    True

After:

kubectl get ipc
NAME                    IPADDRESS    IPASSIGNED   READY   AGE
ipaddressclaim-sample   2.0.0.1/32   True         True    4s

@jstudler jstudler requested a review from bruelea October 1, 2024 10:36
@jstudler jstudler self-assigned this Oct 1, 2024
Copy link
Contributor

@alexandernorth alexandernorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jstudler jstudler merged commit fd9f308 into main Oct 1, 2024
5 checks passed
@henrybear327 henrybear327 deleted the fix/add-age-column branch October 1, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants