Add support for built-in field family in ParentPrefixSelector
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
commented
Nov 20, 2024
jstudler
approved these changes
Nov 20, 2024
Thanks for reviewing @jstudler |
henrybear327
force-pushed
the
feat/add_support_for_family
branch
from
432bfc6 to
f3fdfba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the built-in field
familyinParentPrefixSelector.The CR validation is also written to reject values besides
IPv4andIPv6, when the keyfamilyis present inParentPrefixSelector.The documentation and the sample CR are also updated.