Skip to content

[client] Drop DNS probes for passive health projection #5971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lixmal merged 8 commits into from
May 15, 2026
Merged

[client] Drop DNS probes for passive health projection #5971

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c102592
[client] Drop DNS probes for passive health projection
lixmal Apr 23, 2026
d0f9d80
Harden race fan-out and fix lint
lixmal Apr 23, 2026
db2a62b
[client] Add system DNS fallback for Windows, systemd-resolved, Netwo…
lixmal May 4, 2026
5c9aabf
Merge branch 'main' into drop-dns-probes
lixmal May 6, 2026
a8671e5
Merge remote-tracking branch 'origin/main' into drop-dns-probes
lixmal May 7, 2026
98144e0
Restore value receivers on androidHostManager and reorder iosHostMana…
lixmal May 11, 2026
e8a3e3f
Merge remote-tracking branch 'origin/main' into drop-dns-probes
lixmal May 11, 2026
7859ba1
Propagate EDE meta through race result on upstream short-circuit
lixmal May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions client/internal/dns/local/local.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ func (d *Resolver) ID() types.HandlerID {
return "local-resolver"
}

func (d *Resolver) ProbeAvailability(context.Context) {}

// ServeDNS handles a DNS request
func (d *Resolver) ServeDNS(w dns.ResponseWriter, r *dns.Msg) {
logger := log.WithFields(log.Fields{
Expand Down
9 changes: 3 additions & 6 deletions client/internal/dns/mock_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (

dnsconfig "github.com/netbirdio/netbird/client/internal/dns/config"
nbdns "github.com/netbirdio/netbird/dns"
"github.com/netbirdio/netbird/route"
"github.com/netbirdio/netbird/shared/management/domain"
)

Expand Down Expand Up @@ -70,10 +71,6 @@ func (m *MockServer) SearchDomains() []string {
return make([]string, 0)
}

// ProbeAvailability mocks implementation of ProbeAvailability from the Server interface
func (m *MockServer) ProbeAvailability() {
}

func (m *MockServer) UpdateServerConfig(domains dnsconfig.ServerDomains) error {
if m.UpdateServerConfigFunc != nil {
return m.UpdateServerConfigFunc(domains)
Expand All @@ -85,8 +82,8 @@ func (m *MockServer) PopulateManagementDomain(mgmtURL *url.URL) error {
return nil
}

// SetRouteChecker mock implementation of SetRouteChecker from Server interface
func (m *MockServer) SetRouteChecker(func(netip.Addr) bool) {
// SetRouteSources mock implementation of SetRouteSources from Server interface
func (m *MockServer) SetRouteSources(selected, active func() route.HAMap) {
// Mock implementation - no-op
}

Expand Down
Loading
Loading