Skip to content

Add internal Certificate Authority for peer TLS certificates #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zgv163 wants to merge 18 commits into from

[management,client] Fix rebase conflicts and address remaining review…

4f9be46
Select commit
Loading
Failed to load commit list.
Closed

Add internal Certificate Authority for peer TLS certificates #5491

[management,client] Fix rebase conflicts and address remaining review…
4f9be46
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 5, 2026 in 34s

Quality Gate failed

Failed conditions
6 New issues
6 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 191 in shared/management/http/api/types.gen.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 250 lines of code, which is greater than the 100 authorized. Split it into smaller functions. 

See more on https://sonarcloud.io/project/issues?id=netbirdio_netbird&issues=AZy0wn4x17i-nYl7NpPk&open=AZy0wn4x17i-nYl7NpPk&pullRequest=5491

Check warning on line 91 in management/internals/shared/grpc/conversion.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=netbirdio_netbird&issues=AZy0wn-h17i-nYl7NpPm&open=AZy0wn-h17i-nYl7NpPm&pullRequest=5491

Check warning on line 192 in shared/management/http/api/types.gen.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of switch branches from 123 to at most 30. 

See more on https://sonarcloud.io/project/issues?id=netbirdio_netbird&issues=AZy0wn4x17i-nYl7NpPl&open=AZy0wn4x17i-nYl7NpPl&pullRequest=5491

Check warning on line 116 in management/internals/shared/grpc/conversion.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 16 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=netbirdio_netbird&issues=AZy0wn-h17i-nYl7NpPn&open=AZy0wn-h17i-nYl7NpPn&pullRequest=5491

Check warning on line 79 in management/server/http/handler.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 24 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=netbirdio_netbird&issues=AZy0wn_r17i-nYl7NpPp&open=AZy0wn_r17i-nYl7NpPp&pullRequest=5491

Check failure on line 79 in management/server/http/handler.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 25 to the 20 allowed. 

See more on https://sonarcloud.io/project/issues?id=netbirdio_netbird&issues=AZy0wn_r17i-nYl7NpPo&open=AZy0wn_r17i-nYl7NpPo&pullRequest=5491
View more details on SonarQubeCloud