[mobile] Export lazy connection environment variables for mobile clients#5310
Merged
doromaraujo merged 2 commits intonetbirdio:mainfrom Feb 16, 2026
Conversation
Both for Android and iOS
Contributor
📝 WalkthroughWalkthroughAdds two lazy-connection environment keys to Android and iOS mobile SDKs: Android exposes string constants, iOS exposes getter functions; both map to values from the lazyconn package. Comment for Android's EnvKeyNBForceRelay clarified. Changes
Sequence Diagram(s)(omitted — changes are small API additions without multi-component control-flow needing visualization) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request exports lazy connection environment variables for mobile clients (iOS and Android) to allow configuration from within their sandboxed environments. The changes enable mobile apps to set values for lazy connection features similarly to how Force Relay is currently implemented.
Changes:
- Added exports for lazy connection environment variables (
EnvEnableLazyConnandEnvInactivityThreshold) to both iOS and Android client bindings - Imported the
lazyconnpackage alongside the existingpeerpackage in both mobile platform implementations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| client/ios/NetBirdSDK/env_list.go | Added two getter functions to export lazy connection environment variable keys for iOS gomobile binding |
| client/android/env_list.go | Added two exported package variables for lazy connection environment variable keys for Android Java client |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
pappz
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since both Android and iOS apps run in a sandboxed context, to be able to set values for the lazy connection environment
variables, they will need to be exported to the gomobile generated code, have their values set within their respective apps and exported once they connect to the VPN, similarly how Force Relay is implemented.
Describe your changes
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__
Summary by CodeRabbit