Skip to content

[management] Increment newtork serial on peer update #5051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcmmbaga merged 3 commits into from
Jan 7, 2026
Merged

[management] Increment newtork serial on peer update #5051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2007194
Increment network serial on peer updates
bcmmbaga Jan 7, 2026
dd44366
Prevent double peer updates in SaveOrAddUsers
bcmmbaga Jan 7, 2026
34b12e0
Merge branch 'main' into fix/increment-serial
bcmmbaga Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions management/server/peer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,10 @@ func (am *DefaultAccountManager) UpdatePeer(ctx context.Context, accountID, user
inactivityExpirationChanged = true
}

if err = transaction.IncrementNetworkSerial(ctx, accountID); err != nil {
return fmt.Errorf("failed to increment network serial: %w", err)
}
Comment thread
bcmmbaga marked this conversation as resolved.

return transaction.SavePeer(ctx, accountID, peer)
})
if err != nil {
Expand Down
4 changes: 1 addition & 3 deletions management/server/user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,9 +577,7 @@ func (am *DefaultAccountManager) SaveOrAddUsers(ctx context.Context, accountID,
log.WithContext(ctx).Errorf("failed update expired peers: %s", err)
return nil, err
}
}

if updateAccountPeers {
} else if updateAccountPeers {
if err = am.Store.IncrementNetworkSerial(ctx, accountID); err != nil {
return nil, fmt.Errorf("failed to increment network serial: %w", err)
}
Expand Down
Loading