[management ] remove timing logs

[pascal-fischer]

Describe your changes

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

• I added/updated documentation for this change
• Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

• Chores
  • Removed internal timing and debug logging instrumentation across management server components to streamline logging and maintenance; no functional or behavioral changes visible to end users.

[coderabbitai]

Walkthrough

This pull request removes local timing captures and deferred debug/trace duration logs from several management server functions (peer sync, gRPC response handling, peer management methods, and certain store and types methods). No control flow, return values, or error handling were changed.

Changes

Cohort / File(s)	Change Summary
Peer Synchronization Timing Removal management/server/account.go	Removed local time.Now() start capture and deferred debug duration log from SyncAndMarkPeer
gRPC Server Timing Removal management/server/grpcserver.go	Removed start-time captures and deferred duration debug logs from toSyncResponse and sendInitialSync
Peer Management Timing Removal management/server/peer.go	Removed in-function timing and deferred debug logs from multiple peer methods (MarkPeerConnected, SyncPeer, handlePeerLoginNotFound, LoginPeer, getPeerPostureChecks, getValidatedPeerWithMap, getPeerGroupIDs)
Storage Operations Timing Removal management/server/store/sql_store.go	Removed local timing captures and deferred duration logs from SavePeer, GetAccountNetwork, and GetAccountSettings
Network Map Timing Removal management/server/types/account.go	Removed deferred debug duration log from GetPeerNetworkMap (start time still captured for metrics)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Homogeneous edits: timing/log removals across multiple files.
• Review focus: ensure no accidental removal of functional code or metrics usage, and confirm no retained unused imports (e.g., time, logging packages).
• Files to spot-check: account.go, grpcserver.go, peer.go, sql_store.go, types/account.go.

Poem

🐰 I nibbled the clocks that cluttered the lane,

Logs whispered less, the code felt less grain.
Syncs still hum, responses still race,
Quieted timings leave a tidier place. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description follows the template structure but is largely incomplete; 'Describe your changes' and 'Issue ticket number and link' sections contain no content.	Fill in the 'Describe your changes' section with details about why timing logs were removed and select the refactor checkbox to indicate the PR type.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: removing timing logs from the management module across multiple files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/remove-timing-logs

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4608036 and 870f2e6.

📒 Files selected for processing (1)

• management/server/types/account.go (0 hunks)

💤 Files with no reviewable changes (1)

• management/server/types/account.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)

• GitHub Check: Build Cache
• GitHub Check: Client / Unit
• GitHub Check: Client / Unit
• GitHub Check: Linux
• GitHub Check: Darwin
• GitHub Check: Windows
• GitHub Check: Client / Unit
• GitHub Check: JS / Lint
• GitHub Check: iOS / Build
• GitHub Check: Android / Build
• GitHub Check: release_ui
• GitHub Check: release_ui_darwin
• GitHub Check: release

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud