Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] remove sorting from network map generation #3126

Merged
merged 5 commits into from
Dec 31, 2024

Conversation

pascal-fischer
Copy link
Contributor

Describe your changes

This PR removes the sorting and switches back to a map-based approach as the sorting got very costly for worst-case scenarios

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon mlsmaycon marked this pull request as ready for review December 31, 2024 15:58
@mlsmaycon mlsmaycon self-requested a review December 31, 2024 16:41
Copy link

@pascal-fischer pascal-fischer merged commit 18b049c into main Dec 31, 2024
29 checks passed
@pascal-fischer pascal-fischer deleted the fix/use-maps-in-network-gen branch December 31, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants