Skip to content

Add hover to reverse proxy auth methods#564

Merged
heisbrot merged 1 commit intomainfrom
feature/reverse-proxy-auth
Feb 18, 2026
Merged

Add hover to reverse proxy auth methods#564
heisbrot merged 1 commit intomainfrom
feature/reverse-proxy-auth

Conversation

@heisbrot
Copy link
Copy Markdown
Contributor

@heisbrot heisbrot commented Feb 17, 2026

If multiple auth methods show count and hover
CleanShot 2026-02-17 at 15 13 54<

When only one auth method show it directly
CleanShot 2026-02-17 at 15 14 23

Summary by CodeRabbit

  • New Features

    • ListItem component now supports rendering additional child content
    • Reverse proxy authentication display now includes interactive hover details showing enabled authentication methods and associated user groups
  • Improvements

    • User list now includes both regular and service user accounts
    • Authentication column headers renamed to "Auth Methods" for clarity

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 17, 2026

📝 Walkthrough

Walkthrough

This PR enhances the reverse proxy authentication UI by replacing a simple badge with an interactive HoverCard displaying detailed authentication methods and per-group SSO configurations. It also expands user data sources to include both regular and service users, and restructures the ListItem component to support flexible content layouts.

Changes

Cohort / File(s) Summary
ListItem Component Enhancement
src/components/ListItem.tsx
Added optional children prop, restructured layout to render icon and label on the left and value on the right in a two-part row, and simplified container className styling.
User Data Source Expansion
src/contexts/UsersProvider.tsx
Introduced dual user data sources: regular users and service users. Created combined allUsers array and updated loading state to reflect both sources. Refresh behavior now mutates both user data endpoints.
Reverse Proxy Auth Display
src/modules/reverse-proxy/table/ReverseProxyAuthCell.tsx
Replaced simple enabled badge with HoverCard-based interactive display. Computes enabled authentication methods and renders conditional per-group SSO details (group names, user counts) when bearer authentication is enabled. Integrated useGroups hook and new UI components (HoverCard, GroupBadge, UserCountStack, ListItem).
Reverse Proxy Table Headers
src/modules/reverse-proxy/table/ReverseProxyTable.tsx, src/modules/reverse-proxy/targets/flat/ReverseProxyFlatTargetsTable.tsx
Updated authentication column header text from "Authentication" to "Auth Methods" in both table components.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 The ListItem hops with children in tow,
While users dance—both regular and service flow,
HoverCards bloom with auth methods bright,
Groups parade in rainbow delight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add hover to reverse proxy auth methods' accurately describes the primary change: adding interactive HoverCard functionality to the authentication methods badge in the reverse proxy table.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/reverse-proxy-auth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/modules/reverse-proxy/table/ReverseProxyAuthCell.tsx (1)

61-70: Loose equality check on Line 66.

Minor: prefer strict inequality for filtering.

-        .filter((g): g is Group => g != undefined)
+        .filter((g): g is Group => g !== undefined)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/modules/reverse-proxy/table/ReverseProxyAuthCell.tsx` around lines 61 -
70, The filter in ssoGroups uses a loose inequality (g != undefined); change it
to a strict check so the type guard becomes filter((g): g is Group => g !==
undefined). Update the predicate in the ssoGroups pipeline (which references
auth.bearer_auth.distribution_groups and groups) to use !== to ensure proper
type narrowing to Group.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/modules/reverse-proxy/table/ReverseProxyAuthCell.tsx`:
- Around line 61-70: The filter in ssoGroups uses a loose inequality (g !=
undefined); change it to a strict check so the type guard becomes filter((g): g
is Group => g !== undefined). Update the predicate in the ssoGroups pipeline
(which references auth.bearer_auth.distribution_groups and groups) to use !== to
ensure proper type narrowing to Group.

@heisbrot heisbrot merged commit 829395f into main Feb 18, 2026
4 checks passed
@heisbrot heisbrot deleted the feature/reverse-proxy-auth branch February 18, 2026 12:39
@coderabbitai coderabbitai Bot mentioned this pull request May 1, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants