Skip to content

Enable SSH for Windows and Android peers#532

Merged
lixmal merged 2 commits intomainfrom
enable-ssh-windows
Jan 19, 2026
Merged

Enable SSH for Windows and Android peers#532
lixmal merged 2 commits intomainfrom
enable-ssh-windows

Conversation

@lixmal
Copy link
Copy Markdown
Contributor

@lixmal lixmal commented Jan 19, 2026

  • Allow ssh to windows and android
  • Fix netbird-ssh used instead of tcp/3389 for RDP
  • Hide update badge for temporary peers

Summary by CodeRabbit

  • New Features

    • SSH functionality now available on Windows devices.
  • Improvements

    • Update indicators are suppressed for ephemeral peer connections.
    • Remote-access connections on the RDP page now use a standardized TCP protocol and simplified platform handling (still hidden on iOS).

✏️ Tip: You can customize this high-level summary in your review settings.

@lixmal lixmal changed the title Enable SSH for Windows and Android peers, Enable SSH for Windows and Android peers Jan 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

Adds an optional ephemeral prop to PeerVersionCell (propagated from PeersTable) to suppress update indicators for ephemeral peers; simplifies SSHButton OS checks to hide only on iOS; and hardcodes "tcp" in the RDP connect flow, removing dynamic NetBird SSH/TCP protocol selection.

Changes

Cohort / File(s) Summary
Ephemeral Peer Support
src/modules/peers/PeerVersionCell.tsx, src/modules/peers/PeersTable.tsx
Added ephemeral?: boolean to PeerVersionCell props; component early-exits updateAvailable when ephemeral is true and includes ephemeral in deps. PeersTable now passes ephemeral={row.original.ephemeral} into PeerVersionCell.
SSH Platform Detection
src/modules/remote-access/ssh/SSHButton.tsx
Replaced separate Windows/mobile guards with a single check that SSH is supported when OS is not iOS (broader visibility, iOS-only exclusion).
RDP Connect Protocol
src/app/(remote-access)/peer/rdp/page.tsx
Removed dynamic protocol selection and isNetbirdSSHProtocolSupported import; connectTemporary now uses hardcoded "tcp" for the port/protocol.

Sequence Diagram(s)

(Skipped — changes are small control-flow tweaks across components and do not introduce a new multi-component feature requiring diagramming.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐇 I hop through code with nimble feet,

Ephemeral friends skip update beat,
SSH waves from Windows now so spry,
iOS still keeps the door shut by,
A tcp whisper for RDP — oh my!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the primary changes: enabling SSH for Windows and Android peers by removing OS-based guards and adding ephemeral peer support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lixmal lixmal merged commit 04e22a3 into main Jan 19, 2026
4 checks passed
@lixmal lixmal deleted the enable-ssh-windows branch January 19, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants