Skip to content

Add windows/macos/android instructions for self-hosted #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Add windows/macos/android instructions for self-hosted #254

merged 2 commits into from
Aug 14, 2023

Conversation

bbaumgartl
Copy link
Contributor

@bbaumgartl bbaumgartl commented Aug 9, 2023

Implemented #93

Edit: Added android too

image image image

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2023

CLA assistant check
All committers have signed the CLA.

@bbaumgartl bbaumgartl changed the title Add windows/macos instructions for self-hosted Add windows/macos/android instructions for self-hosted Aug 9, 2023
@bcmmbaga bcmmbaga self-requested a review August 9, 2023 12:40
Copy link
Contributor

@bcmmbaga bcmmbaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bbaumgartl thank you for your valuable contribution. To ensure the effectiveness of these new changes, we should prioritize making them visible in self-hosted using domains other than app.netbird.io or localhost.

why?

  • app.netbird.io is the default domain for netbird. No need to prompt user to change the server.
  • For localhost, it becomes impossible for other remote peers to establish a connection.

@bbaumgartl
Copy link
Contributor Author

Hi @bcmmbaga, i think that's what i already did. I checked how it was done for the other tabs (linux, ubuntu, docker) in common.ts#L7 and common.ts#L20 and applied it here. You can see examples in lines AndroidTab.tsx#L25 and AndroidTab.tsx#L41.

If this is the wrong way could you point me to the correct implementation so i can fix it?

@bcmmbaga
Copy link
Contributor

If this is the wrong way could you point me to the correct implementation so i can fix it

We can proceed with this at the moment

@bcmmbaga bcmmbaga merged commit dedbe55 into netbirdio:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants