Conversation
Contributor
📝 WalkthroughWalkthroughThis pull request updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lixmal
previously approved these changes
Apr 12, 2026
lixmal
previously approved these changes
Apr 13, 2026
lixmal
approved these changes
Apr 13, 2026
lixmal
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After upgrading to v0.4.0, Android users lose all internet connectivity while the VPN is active.
ping duckduckgo.com) results in 100% packet lossFixes #158
Root Cause
The
netbirdsubmodule was bumped from v0.64.1 → v0.68.0, which included [netbirdio/netbird#5739].That change introduced
extraInitialRoutes()to preserve the fake IP block route (240.0.0.0/8) across Android TUN rebuilds. Without it, DNS resolution via fake IPs breaks after the first route update.However, the implementation has an unintended side effect:
extraInitialRoutes()diffs all initial routes against current routes and re-injects missing ones0.0.0.0/0)When
FilterSelectedExitNodesremoves an unselected exit node:extraInitialRoutes()re-injects0.0.0.0/0during TUN rebuild➡️ Result: routing black hole (total internet loss)
Fix
Instead of diffing and re-injecting the entire initial route set:
240.0.0.0/8) explicitly on the notifiernotify()Summary by CodeRabbit