Skip to content

Migrate to ESLint and apply Airbnb JavaScript Style Guide #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Migrate to ESLint and apply Airbnb JavaScript Style Guide #150

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08b9281
Uninstall TSLint
Sep 11, 2019
692539c
Install ESLint and plugins
Sep 11, 2019
eea73ea
Config ESLint with Airbnb Style Guide
Sep 11, 2019
54abab9
Fix ESLint problems
Sep 11, 2019
e3b1037
Config Prettier to align with Airbnb JavaScript Style Guide
Sep 11, 2019
678e911
Extend Prettier glob
Sep 11, 2019
293726e
Remove duplicate write option for Prettier
Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
module.exports = {
parser: '@typescript-eslint/parser',
extends: [
'airbnb-base',
'plugin:import/typescript',
'plugin:@typescript-eslint/recommended',
'prettier',
'prettier/@typescript-eslint',
],
root: true,
env: {
node: true,
jest: true,
},
rules: {
'import/no-extraneous-dependencies': [
'error',
{ devDependencies: ['**/*spec.ts'] },
],
'no-useless-constructor': 'off',
'@typescript-eslint/no-useless-constructor': 'error',
},
};
4 changes: 0 additions & 4 deletions .prettierrc
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions .prettierrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module.exports = {
singleQuote: true,
printWidth: 100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove printWidth option here? (and leave the default value)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule being followed here is https://airbnb.io/javascript/#whitespace--max-len.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but at the same time, 120 is the default option proposed by prettier. So far, we've used prettier's one so I think that we shouldn't change this.

trailingComma: 'all',
};
Loading