-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): support typeorm ^0.3.0 version #1233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Not sure what the current requirement for Nest is but worth noting that TypeORM 0.3.x also drops support for node < 14:
|
Will this change be considered a breaking change for nestjs? If so, does that mean it will be deferred until version |
@dsbert we won't wait till v9 |
this PR is extremely useful since it allows bigger applications to load related entities using multiple queries instead of doing everything in one query with plenty of leftjoins which leads to a cartesian explosion/very long loading times. |
This has been published under the |
This comment was marked as off-topic.
This comment was marked as off-topic.
What is the new recommended way of creating and injecting custom repositories? I understand using the |
any idea of arrival time to stable branch? |
@dsbert I don't know if this is the recommended approach, but at least for my application the transition was very smooth. https://gist.github.com/anchan828/9e569f076e7bc18daf21c652f7c3d012 |
Check if datasource is initialized before destroying it
…s/typeorm into feat/typeorm-0.3-migration
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information