Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): support typeorm ^0.3.0 version #1233

Merged
merged 9 commits into from
Jun 1, 2022

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Upgrade

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

@lovetodream lovetodream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

lib/common/typeorm.decorators.ts Outdated Show resolved Hide resolved
@zbarbuto
Copy link

zbarbuto commented Apr 3, 2022

Not sure what the current requirement for Nest is but worth noting that TypeORM 0.3.x also drops support for node < 14:

compilation target now is es2020. This requires Node.JS version 14+

@dsbert
Copy link
Contributor

dsbert commented Apr 4, 2022

Will this change be considered a breaking change for nestjs? If so, does that mean it will be deferred until version 9? There are some features we are hoping to utilize from the latest TypeORM, so I'm just wondering what the potential timeline could be and if we need to look at alternative solutions in the interim.

@kamilmysliwiec
Copy link
Member Author

@dsbert we won't wait till v9

@Rainson12
Copy link

this PR is extremely useful since it allows bigger applications to load related entities using multiple queries instead of doing everything in one query with plenty of leftjoins which leads to a cartesian explosion/very long loading times.

@kamilmysliwiec
Copy link
Member Author

This has been published under the next tag (npm i @nestjs/typeorm@next)

@msonowal

This comment was marked as off-topic.

@dsbert
Copy link
Contributor

dsbert commented Apr 10, 2022

What is the new recommended way of creating and injecting custom repositories? I understand using the extend function now on a normal repository, but is there an example of how that should work with the DI system?

@DEG-CD
Copy link

DEG-CD commented Apr 10, 2022

any idea of arrival time to stable branch?

@anchan828
Copy link

@dsbert I don't know if this is the recommended approach, but at least for my application the transition was very smooth.

https://gist.github.com/anchan828/9e569f076e7bc18daf21c652f7c3d012

@nestjs nestjs locked as too heated and limited conversation to collaborators Apr 11, 2022
@kamilmysliwiec kamilmysliwiec merged commit 9271d25 into master Jun 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat/typeorm-0.3-migration branch June 1, 2022 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants