Skip to content

build: do not remove comments #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2021
Merged

build: do not remove comments #1064

merged 1 commit into from
Nov 15, 2021

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

When using this package, we don't get any of those useful comments on typescript interfaces because they were dropped due to removeComments flag

image

What is the new behavior?

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@micalevisk micalevisk changed the title buidl: do not remove comments build: do not remove comments Nov 12, 2021
@kamilmysliwiec
Copy link
Member

Great catch! Thank you

@kamilmysliwiec kamilmysliwiec merged commit 423b500 into nestjs:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants