Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): fix errors #1029

Merged

Conversation

LeoAnesi
Copy link
Contributor

@LeoAnesi LeoAnesi commented Oct 9, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: While working on another PR to allow connection name in forRoot I saw that the lint command was broken and once fixed I saw errors that weren't related to my code, this PR fix those issues. 

Other information

I ignored @typescript-eslint/ban-types for Function type because it looks difficult to fix, but maybe a better option would have been to put eslint-ignores in current uses to prevent future additions of Function, tell me if so I'll change it.

@@ -9,7 +9,6 @@ module.exports = {
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'prettier',
'prettier/@typescript-eslint',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilmysliwiec kamilmysliwiec merged commit 13b9cdc into nestjs:master Oct 18, 2021
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants