feat(common): add log filtering function#14793
Merged
kamilmysliwiec merged 2 commits intonestjs:masterfrom May 5, 2025
Merged
Conversation
1 task
Member
|
CI checks fail
|
Contributor
Author
|
@kamilmysliwiec my bad, i wrongly assumed jest as test framework. |
Pull Request Test Coverage Report for Build e4bab927-b865-4045-832d-4034ee7ca44eDetails
💛 - Coveralls |
Contributor
Author
|
@kamilmysliwiec tests are not passing but it's unrelated to my code. what to do here? 
|
Member
|
Can just rebase/merge master as it's already been fixed in the upstream |
y-nk
force-pushed
the
julien/log-level-filtering
branch
from
b081f4d to
c0327c9
Compare
Contributor
Author
|
@kamilmysliwiec done! |
Member
|
|
Contributor
Author
|
@kamilmysliwiec oh damn this got reverted when i rebased 😓 let me push it again |
y-nk
force-pushed
the
julien/log-level-filtering
branch
from
c0327c9 to
bb9e847
Compare
Contributor
Author
|
@kamilmysliwiec sorry for the bad rebase. all is green now 🙏! |
benjGam
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
log levels can be passed manually
Issue Number: 14788
What is the new behavior?
a function which helps to smartly parse log level based on string (ideally, env var)
Does this PR introduce a breaking change?
Other informations
Since issue was not yet seen, I'll wait for feedback before providing docs, but as you can see in the original issue, doc-friendly explanation was already provided.