Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(websockets): ensure non-shared servers call close method #14204

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

sapenlei
Copy link
Contributor

@sapenlei sapenlei commented Nov 26, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

When forceCloseConnections is enabled, non-shared HTTP servers are not being properly closed.

What is the new behavior?

When forceCloseConnections is enabled, non-shared HTTP servers should be closed by WS.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4c4cc718-726a-4220-b5c9-b60fa58e9ff1

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.944%

Totals Coverage Status
Change from base Build f8530e24-4ee6-4945-a04b-213174f935d6: 0.0%
Covered Lines: 6814
Relevant Lines: 7411

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 8102325 into nestjs:master Nov 26, 2024
5 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants