chore(core): defer application shutdown until init finishes #14139
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mksony
force-pushed
the
chore/ensure-application-init-before-accepting-sigterm
branch
3 times, most recently
from
e982781
to
3522c4d
Compare
mksony
force-pushed
the
chore/ensure-application-init-before-accepting-sigterm
branch
from
3522c4d
to
5c6986f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Not fully sure if this is a bugfix or feature. I guess one could argue in both directions.
What is the current behavior?
If you use lifecycle methods during startup of the nestjs applications with async operations with calls e.g. to the database, message/job processing and you receive a SIGTERM signal it can happen that the connections required for the async operations are closed while executing those async operations. For us this happened now and then in our K8s cluster where the process can be terminated at any time. That can lead to unexpected errors.
Issue Number: N/A
What is the new behavior?
When a shutdown is requested via the incoming termination signal, the application defers calling the shutdown hooks until the app is fully initialized.
Does this PR introduce a breaking change?
Other information