-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(express): upgrade to express 4.2.1 #14060
Merged
kamilmysliwiec
merged 1 commit into
nestjs:master
from
ezintz:fix-express-vulnerabilities
Oct 16, 2024
Merged
build(express): upgrade to express 4.2.1 #14060
kamilmysliwiec
merged 1 commit into
nestjs:master
from
ezintz:fix-express-vulnerabilities
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes vulnerabilites with cookie and path-to-regexp, see GHSA-pxg6-pf52-xh8x GHSA-9wv6-86v2-598j
Pull Request Test Coverage Report for Build 85c24b08-dacd-4f9a-9550-fa7cfadfb80bDetails
💛 - Coveralls |
15 tasks
micalevisk
approved these changes
Oct 10, 2024
sans-jmansfield
approved these changes
Oct 11, 2024
LordMendes
approved these changes
Oct 11, 2024
Tony133
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of the PR should be corrected to build(express): upgrade to express 4.21.1
, to specify better 😉, the strange thing is who knows why the dependabot
or renovate
does not automatically generate these corrections of security ? 🤔
kamilmysliwiec
added
the
dependencies
Pull requests that update a dependency file
label
Oct 16, 2024
LGTM |
This was referenced Nov 7, 2024
This was referenced Nov 8, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes vulnerabilites with cookie and path-to-regexp.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently security scanners like Anchore or Trivy are reporting vulnerabilities from express for certain packages. Please see
What is the new behavior?
Security scanners will not report vulnerabilities for the installed express package anymore.
Does this PR introduce a breaking change?
Other information