Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(express): upgrade to express 4.2.1 #14060

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ezintz
Copy link
Contributor

@ezintz ezintz commented Oct 10, 2024

fixes vulnerabilites with cookie and path-to-regexp.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: fixes security vulnerabilities coming from the express package, which has already updated dependencies

What is the current behavior?

Currently security scanners like Anchore or Trivy are reporting vulnerabilities from express for certain packages. Please see

What is the new behavior?

Security scanners will not report vulnerabilities for the installed express package anymore.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fixes vulnerabilites with cookie and path-to-regexp, see
GHSA-pxg6-pf52-xh8x
GHSA-9wv6-86v2-598j
@coveralls
Copy link

Pull Request Test Coverage Report for Build 85c24b08-dacd-4f9a-9550-fa7cfadfb80b

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.213%

Totals Coverage Status
Change from base Build 9327011d-4e25-476d-80b9-dcb00dcd9e2d: 0.0%
Covered Lines: 6750
Relevant Lines: 7320

💛 - Coveralls

Copy link
Contributor

@Tony133 Tony133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR should be corrected to build(express): upgrade to express 4.21.1, to specify better 😉, the strange thing is who knows why the dependabot or renovate does not automatically generate these corrections of security ? 🤔

@kamilmysliwiec kamilmysliwiec added the dependencies Pull requests that update a dependency file label Oct 16, 2024
@kamilmysliwiec kamilmysliwiec merged commit 508d2f3 into nestjs:master Oct 16, 2024
3 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants