Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fastify): Do not crash if enableVersioning is not used #13536

Conversation

Fcmam5
Copy link
Contributor

@Fcmam5 Fcmam5 commented May 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #13496

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Fcmam5 Fcmam5 force-pushed the fix/do-not-crash-when_not_using-enabledVersioning branch from b65b496 to c0af8af Compare May 5, 2024 07:26
@coveralls
Copy link

coveralls commented May 5, 2024

Pull Request Test Coverage Report for Build 9ab9e29c-a6c7-418a-943d-6f81a0507a00

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.124%

Totals Coverage Status
Change from base Build e56f6d99-d9bc-426a-b9ef-ed11406d7e1c: 0.0%
Covered Lines: 6737
Relevant Lines: 7313

💛 - Coveralls

Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'd have to change the versioningOptions field definition to mark it as optional

@Fcmam5
Copy link
Contributor Author

Fcmam5 commented May 6, 2024

@micalevisk I agree, I just pushed now. Please check again

@Fcmam5 Fcmam5 requested a review from micalevisk May 18, 2024 10:32
@kamilmysliwiec kamilmysliwiec merged commit 2d5a7b8 into nestjs:master Jun 3, 2024
5 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants