fix: #13077 KafkaJs typing consistency #13084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Incompatible typing between the KafkaJs and Nest Kafka Microservice types.
Issue Number: #13077
What is the new behavior?
This will change the SASL Mechanism to be compatible types.
Does this PR introduce a breaking change?
While technically this is a breaking change, since we Object.assign, the current signature actually won't work: https://github.com/edeesis/nest/blob/master/packages/microservices/server/server-kafka.ts#L114-L118.
The signature change was introduced in kafkajs 2.2.1.
Other information