feat(core): add options parameter to repl

[othierry]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

What is the current behavior?

The nestjs/core/repl function that runs node:repl does not allow the consumers to provide node:repl's option (ReplOptions).

Issue Number: #12916

What is the new behavior?

This PR allows passing ReplOptions to the nestjs/core/repl function. Current implemented behavior will also override default options prompt / ignoreUndefined if they are provided. If required, I can change the PR to not override this default options.

Does this PR introduce a breaking change?

• Yes
• No

Other information

• I don't know if a test for this is required or not (we are just adding a new paramter whose type is defined within node typings itself). If a test is expected for this, it would be nice to have an hint of exactly "what" to test for to avoid writing uncessary code/tests.

[coveralls]

Pull Request Test Coverage Report for Build 8e7cb4c5-2c2a-40ff-bd50-32f96d6b3646

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage remained the same at 92.258%

---

Files with Coverage Reduction	New Missed Lines	%
packages/core/repl/repl.ts	1	50.0%

Totals
Change from base Build a2138bee-e39e-445f-b2ab-320ae7840dc5:	0.0%
Covered Lines:	6697
Relevant Lines:	7259

---

💛 - Coveralls

[micalevisk]

so now users can change the prompt. That's good, to me

But I wonder if changing the ignoreUndefined will break the repl 🤔 I don't why we're using ignoreUndefined: true tbh

[othierry]

I wondered the same thing. Not really sure why ignoreUndefined is set to true but there's probably a reason behind ?

That's how it behaves :

• node repl

> undefined
undefined

• nestjs repl

> undefined
>

It's actually weird haha.

If we can confirm this is required, I can move the replOptions spread at the begining but that would prevent users to change the promp. I clould also force ignoreUndefined: true but keep the rest of replOptions. (and make it clear for users in typing like : Omit<ReplOptions, 'ignoreUndefined'>)

wdyt ?

[kamilmysliwiec]

lgtm