feat(fastify): add fastify route constraints #12567
Conversation
Pull Request Test Coverage Report for Build cbd84d10-1848-4993-bb19-f51e0f22f903
💛 - Coveralls |
| import { SetMetadata } from '@nestjs/common'; | ||
| import { FASTIFY_ROUTE_CONSTRAINTS_METADATA } from '../constants'; | ||
|
|
||
| type IRouteConstraints = { version?: any; host?: any; [name: string]: any }; |
There was a problem hiding this comment.
can't we use fastify types here? it's a hard dep of @nestjs/platform-fastify package
There was a problem hiding this comment.
RouteOptions['constraints'] only defines { [name: string]: any }, while they explicitly mention version and host in the documentation (in addition the custom async constraints).
I will file an issue to Fastify to see if we can use this interface instead.
Update: I submitted fastify/fastify#5097 in case we want to use Fastify types
There was a problem hiding this comment.
fastify/fastify#5097 has just been merged
There was a problem hiding this comment.
I will amend my PR once a new version of Fastify is released
There was a problem hiding this comment.
@kamilmysliwiec @micalevisk please check now, fastify v4.25.0 has been released with fastify/fastify#5097
Fcmam5
force-pushed
the
feature/fastify-route-constraints
branch
from
df96d74
to
00e0c34
Compare
Fcmam5
force-pushed
the
feature/fastify-route-constraints
branch
from
00e0c34
to
4468928
Compare
…fastify-route-constraints
|
@Fcmam5 why we're changing the root |
I updated Fastify (as promised in #12567 (comment)) before an earlier PR was merged. I will revert the changes there as it seems to downgrade Please @micalevisk have a look now |
|
lgtm |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #12496
What is the new behavior?
This adds a new
@RouteConstraintsdecorator to specify Fastify route constraintsPoC and Examples:
https://github.com/Fcmam5/fastify-route-constraints-poc#readme
Does this PR introduce a breaking change?
Other information