Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove deprecated type deps #10606

Merged
merged 1 commit into from
Nov 29, 2022
Merged

build: remove deprecated type deps #10606

merged 1 commit into from
Nov 29, 2022

Conversation

aradwann
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

the packages:
"@types/redis": "4.0.11",
"@types/reflect-metadata": "0.1.0"
are deprecated and the libraries provide their own types, so those won't be needed

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build e8eecd0e-862c-43be-a891-b37c9c503993

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.404%

Totals Coverage Status
Change from base Build a213a525-4c5b-48ee-9803-b76e72178509: 0.0%
Covered Lines: 6202
Relevant Lines: 6640

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit ef917e0 into nestjs:master Nov 29, 2022
@kamilmysliwiec
Copy link
Member

LGTM

@aradwann aradwann deleted the remove-deprecated-type-dependencies branch November 29, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants