-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump fastify from 4.9.2 to 4.10.2 #10583
Conversation
Bumps [fastify](https://github.com/fastify/fastify) from 4.9.2 to 4.10.2. - [Release notes](https://github.com/fastify/fastify/releases) - [Commits](fastify/fastify@v4.9.2...v4.10.2) --- updated-dependencies: - dependency-name: fastify dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Pull Request Test Coverage Report for Build 3cd8035e-566b-4f83-8df3-f4fbf70c1d27
💛 - Coveralls |
This fixes GHSA-3fjj-p79j-c9hh |
when can we expect this to be merged? |
Same, waiting for this to be merged 😢 |
Tip🏓 @ufec If it is just a matter of upgrading the for NPM v8+
"overrides": {
"@nestjs/platform-fastify": {
"fastify": "$fastify"
}
} If "overrides": {
"@nestjs/platform-fastify": {
"fastify": "^4.10.2"
}
}
These two are the ones I tried and they worked here. |
@micalevisk the suggestion works, but we use an internal common module that wraps different utilities around the platform-fastify and nestjs that is where we have the platform-fastify installed, also we have tons of microservices over 70 that use that utility, and that means that for every microservice we have to go and add "overrides": {
"@nestjs/platform-fastify": {
"fastify": "^4.10.2"
}
} as it is not propagating from the common module configuration. Also, this is a temporary change as when this PR is merged we will have to remove the overrides from every single place... I am wondering if there could be another way to allow the manual fastify version update in the future, may be with peer dependency and weaker limitations.. |
@goriunov got you I don't see why we couldn't move fastify to peer dep instead in the next major bump. But that is probably something that Kamil had evaluated in the past. |
@micalevisk I am currently trying to resolve the fastify security vulnerability and I am forced to upgrade @nestjs/platform-fastify to V9 because fastify was upgraded to a non-vulnerable version in nest v9 but our current nest version is v8 and we don't want to upgrade to v9 just yet, is there any way I can resolve the vulnerability and still remain on the same version? |
Bumps fastify from 4.9.2 to 4.10.2.
Release notes
Sourced from fastify's releases.
... (truncated)
Commits
62dde76
Merge pull request from GHSA-3fjj-p79j-c9hh6fc06c1
Bumped v4.10.1a8873ef
add silent option to LogLevel (#4432)9c1be2a
build(deps-dev): bump@sinonjs/fake-timers
from 9.1.2 to 10.0.0 (#4421)9c85bed
Add fastify-constraints to community plugins (#4428)36d84bc
fix node 19.1.0 port validation test (#4427)3767bc2
Bumped v4.10.05c8039c
docs: fix removeAdditional refer (#4410)ea58581
docs: fix example using db decorator on fastify instance (#4406)675b00d
docs: Document multiple app approach (#4393)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.