Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency ws to v8.17.1 [security] - autoclosed #3217

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(deps): update dependency ws to v8.17.1 [security] - autoclosed #3217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/graphql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"subscriptions-transport-ws": "0.11.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package still has the vulnerable ws package installed. Like savilde said here https://github.com/nestjs/graphql/issues/3215 this package is deprecated and should be changed to graphql-ws

Copy link

@SiebelsTim SiebelsTim Jun 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refs #2775

subscriptions-transport-ws depends on "ws": "^5.2.0 || ^6.0.0 || ^7.0.0".

Since the CVE is fixed in 5.2.4, 6.2.3, 7.5.10, 8.17.1, I don't think we need to remove subscriptions-transport-ws to resolve the CVE.

"tslib": "2.6.2",
"uuid": "9.0.1",
"ws": "8.16.0"
"ws": "8.17.1"
},
"devDependencies": {
"@apollo/subgraph": "2.2.3",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11316,10 +11316,10 @@ [email protected]:
type-fest "^0.4.1"
write-json-file "^3.2.0"

ws@8.16.0:
version "8.16.0"
resolved "https://registry.yarnpkg.com/ws/-/ws-8.16.0.tgz#d1cd774f36fbc07165066a60e40323eab6446fd4"
integrity sha512-HS0c//TP7Ina87TfiPUz1rQzMhHrl/SG2guqRcTOIUYD2q8uhUdNHZYJUaQ8aTGPzCh+c6oawMKW35nFl1dxyQ==
ws@8.17.1:
version "8.17.1"
resolved "https://registry.yarnpkg.com/ws/-/ws-8.17.1.tgz#9293da530bb548febc95371d90f9c878727d919b"
integrity sha512-6XQFvXTkbfUOZOKKILFG1PDK2NDQs4azKQl26T0YS5CxqWLgXajbPZ+h4gZekJyRqFU8pvnbAbbs/3TgRPy+GQ==

"ws@^5.2.0 || ^6.0.0 || ^7.0.0":
version "7.5.9"
Expand Down