Skip to content

Conversation

@VictorOluwaseun
Copy link
Contributor

@VictorOluwaseun VictorOluwaseun commented Oct 19, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

In the CQRS → Queries example, the GetHeroHandler incorrectly uses query.hero,
even though the GetHeroQuery class defines the property as heroId.
This causes an inconsistency in the example code and may confuse readers following the docs.

What is the new behavior?

The example has been corrected to use query.heroId, matching the property defined in the GetHeroQuery class.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 03323c5 into nestjs:master Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants