feat: ability to disable debug message in ConditionalModule #1677
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option `debug` defaulted to true to the `registerWhen` method and only create debug log when it is set to true. Also fix type for options.timeout to be optional.
micalevisk
approved these changes
Apr 4, 2024
|
LGTM |
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option
debugdefaulted to true to theregisterWhenmethod and only create debug log when it is set to true. Also adjust the type for options.timeout to be optional.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently a ConditionalModule is run when a javascript module is loaded but before any NestJS setup occurs. The ConditionalModule. In this case, the module will output a debug log via the default ConsoleLogger with no ability to silence the message.
Issue Number: N/A
What is the new behavior?
Add an option to the ConditionalModule's registerWhen method to disable the debug message.
Does this PR introduce a breaking change?
Other information
The debug flag is defaulted to true so that no change will be observed, however the timeout option is being flagged as optional so previous code that would have shown a type error with an empty object will now pass.