Port upstream CodexBar 0.54.0 - #353
Conversation
Thermo-Nuclear Code Quality Review — APPROVEVerdictWell-structured port. New capabilities properly modularized. No structural regressions. Findings1. Structural regressions — None. 58 files, +2767/-187. Largest growth is 2. Code-judo — One minor nit, not a blocker. 3. Spaghetti / branching — Clean. The 4. Type/boundary — Clean. 5. New files — Well-modularized. Each of the 5 new files owns one capability: PAT usage (183 lines), Grok local sessions (175), OpenCode Go usage API (125), OpenRouter Activity parser (217), Antigravity idle filtering (64). No god-objects, no thin wrappers. 6. Provider-specific logic in shared paths — Acceptable. 7. Historical pricing — Clean. 8. Test quality — Strong. OpenCodex routing tests cover provider-label vs model-prefix precedence. Fireworks covers empty/single/multiple slug discovery. Codex PAT covers token parsing, user-agent normalization, fallback narrowness. Historical pricing verifies rate changes at exact cutoff. Antigravity covers known-idle, unknown-zero, global-reset. OpenRouter Activity covers dedup, range filtering, conflict detection. ApprovalNo structural regression, no file-size explosion, no spaghetti growth, no hacky abstractions, no boundary leaks. Approve. |
Summary
Ports the Windows-applicable behavior from upstream CodexBar v0.54.0 into the Rust/Tauri rewrite. This is a behavior port from tag-pinned upstream sources, not a Swift code transplant and not a Win-CodexBar release/version bump.
Ported
Amp <plan> Subscription:parsing while retaining legacy format (982ca9069).33e6e6558).00598dae1)./wham/usageand narrow Auto fallback (a91646c16).bed146c63).06b36572f).99234b5c3).670f05333).155d82505,c5f7625bc).codexbar serveintegration docs (fc7040e39).Skipped with evidence
Bundle.allBundlescrash: no Windows/Tauri/Rust counterpart.Deferred: none. Every v0.54.0 release-note item has a PORT or SKIP disposition.
Validation
cargo fmt --all -- --checkPASS.cargo clippy --workspace --all-targets -- -D warningsPASS.cargo test --workspace: 1320/1321 PASS locally. The only failure is the known CodexPro PTY environment limitationcli::tty_runner::tests::test_run_sends_script_through_pty -> BinaryNotFound("cmd"); this PR requires hosted Windows CI to pass the full workspace suite before merge.git diff --checkPASS.scripts/local-check.ps1was not accepted as evidence locally because this shell environment fails to initialize$LASTEXITCODEwhen itscargoshim does not execute. The exact hosted CI commands above were therefore run directly with the real Cargo/Node binaries.Fresh Windows / CUA proof
Fresh desktop build from the committed branch head:
tauri build --debug --no-bundle->target/debug/codexbar-desktop-tauri.exePASS.CUA proof on that binary:
proof-054-show-pace.png: Settings -> Menu exposesShow pace; UIA helper text confirms it controls usage pace, on-pace budgets, and forecast text.proof-054-usage-spend.png: Settings -> Usage & Spend exposes separateCopy JSONandSave JSON…controls.proof-054-openrouter-management.png: Settings -> Providers -> OpenRouter exposes a separateManagement API keyinput; UIA help explicitly scopes it to exact 30-day Activity spend fromopenrouter.aiand keeps the primary API key separate.No credential was entered during proof. One proof process retained only its float bar after the settings window was closed; it was not force-terminated.
Upstream interaction
No issues, PRs, comments, pushes, or other writes were made to
steipete/CodexBar. Upstream was used only through public tag-pinned release/source history.